felipepessoto commented on code in PR #12967:
URL: https://github.com/apache/gluten/pull/12967#discussion_r3936638360
##########
cpp/velox/tests/VeloxSubstraitRoundTripTest.cc:
##########
@@ -205,6 +205,33 @@ TEST_F(VeloxSubstraitRoundTripTest, countAll) {
assertPlanConversion(plan, "SELECT count(*) as num_price FROM tmp WHERE c6 <
24 GROUP BY c0, c1");
}
+TEST_F(VeloxSubstraitRoundTripTest, minMaxTimestampUtc) {
+ const auto minTimestamp = Timestamp(-1, 999'000'000);
+ const auto maxTimestamp = Timestamp(1'704'067'200, 123'000'000);
Review Comment:
Good catch. Updated the round-trip test to use the Spark-prefixed min/max
implementation with microsecond-level values, and added an explicit assertion
that the emitted Substrait PrecisionTimestamp has precision 6. The focused
native tests pass in e6e42bd55f.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
