pedrumj2 commented on code in PR #13016:
URL: https://github.com/apache/gluten/pull/13016#discussion_r4020600233
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxRuleApi.scala:
##########
@@ -67,6 +68,11 @@ object VeloxRuleApi {
if (BackendsApiManager.getSettings.supportAppendDataExec()) {
injector.injectPlannerStrategy(SparkShimLoader.getSparkShims.getRewriteCreateTableAsSelect(_))
}
+
+ // Makes a UDF loaded from `udfLibraryPaths` resolvable by its own name.
Injected through
+ // SparkInjector so InjectorControl turns a call made while Gluten is
disabled into an
+ // analysis-time error rather than a failure at execution.
+ UDFResolver.getFunctionDescriptions.foreach(injector.injectFunction)
Review Comment:
@marin-ma I added two new test under VeloxUDFSuite.scala. Please let me
know if this addresses this concern above.
> Please add Spark-level coverage using the existing native-UDF test setup,
with the required test placed under gluten-ut/.
With regards to moving under `gluten-ut` the changes would be a bit more
involved. Would that be a blocker for this change or can we open a separate
issue for this? Based on my understanding:
- There seems to be an .so file that the tests need
[here](https://github.com/pedrumj2/gluten/blob/45be7dc48129de55890126574b575b75d4cb9838/backends-velox/src/test/scala/org/apache/gluten/expression/VeloxUdfSuite.scala#L44-L53)
- the .so file is passed in via maven for `backends-velox` for the
[pom.xml](https://github.com/apache/gluten/blob/f04968b1083b12c0a13581fdaa36003b3fd1a87f/backends-velox/pom.xml#L325-L335)
but not included for the `gluten-ut`
[pom.xml](https://github.com/apache/gluten/blob/f04968b1083b12c0a13581fdaa36003b3fd1a87f/gluten-ut/spark35/pom.xml#L81-L95)
digging further seems we need to enable the CI jobs for gluten-ut to also
build this .so file then make sure we include it under the gluten-ut scalatest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
