yikf opened a new pull request, #13031:
URL: https://github.com/apache/gluten/pull/13031

   ## What changes were proposed in this pull request?
   
   Two tests in `GlutenSQLAggregateFunctionSuite` (Spark 4.0 and 4.1 UT 
modules) were disabled with `ignoreGluten` when the suite was ported to Spark 
4.0/4.1, each carrying a stale `// TODO: fix in Spark-4.0` note. Their test 
bodies are byte-for-byte identical to the Spark 3.5 versions that run as 
`testGluten` and pass. This PR re-enables them and removes the outdated TODOs:
   
   - `GLUTEN-4853: The result order is reversed for count and count distinct`
   - `Return NaN or null when dividing by zero`
   
   Affected files:
   - 
`gluten-ut/spark40/src/test/scala/org/apache/spark/sql/execution/GlutenSQLAggregateFunctionSuite.scala`
   - 
`gluten-ut/spark41/src/test/scala/org/apache/spark/sql/execution/GlutenSQLAggregateFunctionSuite.scala`
   
   ## How was this patch tested?
   
   Existing tests re-enabled. Verified `spotless:check` passes and the edited 
files compile clean under `-Pspark-4.0 -Pjava-17 -Pscala-2.13`. Actual UT 
execution requires the native library and is left to CI.
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude claude-opus-4-8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to