felipepessoto opened a new issue, #13037:
URL: https://github.com/apache/gluten/issues/13037

   ### Description
   
   `.github/workflows/util/delta-spark-ut/setup-delta.sh` currently mixes Delta 
checkout and Gluten test-harness setup with temporary compatibility/workaround 
patches applied to the cloned Delta sources. As more patches are added, this 
makes the setup flow harder to read, test, and retire when the pinned Delta 
version advances.
   
   Extract the temporary Delta test patches into a dedicated script such as 
`.github/workflows/util/delta-spark-ut/apply-delta-test-patches.sh`. The 
extracted script should contain:
   
   - the cherry-pick helper and upstream `FileSourceScanLike` test fixes from 
delta-io/delta#7104 and delta-io/delta#7105;
   - the deterministic `parquet.block.rows` fixture patch introduced by #13036;
   - the fail-fast patch for the two memory-heavy `DeletionVectorsSuite` 
2-billion-row tests.
   
   Keep environment/setup responsibilities in `setup-delta.sh`, including 
argument validation, cloning and checking out Delta, placing the Gluten bundle 
on the test classpath, and replacing `DeltaSQLCommandTest.scala` to enable 
Gluten in the Delta test harness.
   
   The extracted script should:
   
   - accept the Delta directory and pinned ref explicitly;
   - preserve the existing patch ordering;
   - remain safe for the current shallow clone;
   - validate expected files and exact patch counts so source drift fails 
loudly;
   - print the resulting source diff;
   - make each temporary patch easy to identify and remove after an upstream 
fix or Delta version upgrade;
   - preserve the existing setup and test behavior.
   
   Generated-by: GitHub Copilot App 1.0.84-5
   
   ### Gluten version
   
   main branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to