felipepessoto commented on PR #12967: URL: https://github.com/apache/gluten/pull/12967#issuecomment-5694533045
Addressed both suggestions from [this review](https://github.com/apache/gluten/pull/12967#pullrequestreview-5219697921) in [b97a45a9d2](https://github.com/apache/gluten/commit/b97a45a9d2e43d1aa0936b14db2131ead3a9e784). Added a grouped min/max regression with a `TIMESTAMP_NTZ` grouping key and a separate NTZ value column. It checks exact per-key results and requires every aggregate stage to be native with an NTZ grouping key. The inputs include keys one microsecond apart, null keys, and an all-null value group. Updated the `VeloxConfig.ENABLE_TIMESTAMP_NTZ_VALIDATION` description and regenerated `docs/velox-configuration.md`. The documentation now explains that `false` permits supported NTZ scans, aggregates, shuffles and projections, while other operator, expression and native validation rules still apply. The flag and its default are unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
