rui-mo commented on code in PR #13002:
URL: https://github.com/apache/gluten/pull/13002#discussion_r4025777909
##########
gluten-substrait/src/main/scala/org/apache/gluten/utils/DecimalArithmeticUtil.scala:
##########
@@ -62,6 +62,9 @@ object DecimalArithmeticUtil {
resultPrecision = intDig + decDig
resultScale = decDig
}
+ // Remainder and Pmod land here: isDecimalArithmetic admits them but no
result type is
+ // derived above. On the transformCheckOverflow path this throw is what
makes decimal % and
+ // pmod fall back.
Review Comment:
Thanks for checking! I didn’t realize that Velox doesn’t support the decimal
type for `remainder` and `pmod`. It makes sense to address this in a separate
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
