felipepessoto commented on code in PR #13042:
URL: https://github.com/apache/gluten/pull/13042#discussion_r4032737035
##########
gluten-delta/src/main/scala/org/apache/gluten/extension/OffloadDeltaScan.scala:
##########
@@ -55,9 +57,8 @@ case class OffloadDeltaScan(enableNativeDmlRowIndexScan:
Boolean) extends Offloa
case scan: FileSourceScanExec if
shouldFallbackSpark34DeletionVectorScan(scan) =>
FallbackTags.add(scan, "fallback Spark 3.4 Delta DV scan")
scan
- case scan: FileSourceScanExec
- if shouldFallbackDeletionVectorScanWithoutMetadataRowIndex(scan) =>
- FallbackTags.add(scan, "fallback Delta DV scan without metadata row
index")
+ case scan: FileSourceScanExec if
shouldFallbackGeneratedDeletionVectorMetadataScan(scan) =>
Review Comment:
Fixed in 4ac80552d. The generated-DV-metadata fallback now first requires
`DeltaScanUtils.isDeltaScan(scan)`, so unrelated Parquet scans with matching
user column names remain eligible for native conversion. I also added focused
coverage for the temporary row-index field noted in the review summary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
