marin-ma commented on PR #12984: URL: https://github.com/apache/gluten/pull/12984#issuecomment-5728601582
@kecookier `GlutenByteInputStream` is a copy from Velox code because they removed the original one: https://github.com/apache/gluten/pull/6872#discussion_r1719256302 Do you think we can remove `GlutenByteInputStream` now and only maintain `VeloxInputStream`? I would suggest rename `VeloxInputStream` to `RssSortShuffleReaderInputStream` as it's only targeted for rss sort shuffle reader. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
