philo-he commented on code in PR #12873:
URL: https://github.com/apache/gluten/pull/12873#discussion_r4080005663
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -1251,6 +1251,68 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi
with Logging {
GenericExpressionTransformer(substraitExprName, child, expr)
}
+ override def genEltTransformer(
+ substraitExprName: String,
+ children: Seq[ExpressionTransformer],
+ expr: Elt): ExpressionTransformer = {
+ // Velox's elt derives whether an out-of-range index raises an error from
the session's
+ // 'spark.sql.ansi.enabled', while Spark captures it in Elt.failOnError at
analysis time.
+ // The two normally agree; fall back when they don't, so the ANSI behavior
never diverges.
+ if (expr.failOnError != SQLConf.get.ansiEnabled) {
+ GlutenExceptionUtil
+ .throwsNotFullySupported(
+ ExpressionNames.ELT,
+ EltRestrictions.NOT_SUPPORT_FAIL_ON_ERROR_MISMATCH
+ )
+ }
+ GenericExpressionTransformer(substraitExprName, children, expr)
+ }
+
+ override def genConvTransformer(
+ substraitExprName: String,
+ children: Seq[ExpressionTransformer],
+ expr: Conv): ExpressionTransformer = {
+ // Velox derives whether an overflow raises an error from the session's
+ // 'spark.sql.ansi.enabled', while Spark captures it in Conv.ansiEnabled
at analysis time.
+ // The two normally agree; fall back when they don't, so the ANSI behavior
never diverges.
+ if (expr.ansiEnabled != SQLConf.get.ansiEnabled) {
+ GlutenExceptionUtil
+ .throwsNotFullySupported(
+ ExpressionNames.CONV,
+ ConvRestrictions.NOT_SUPPORT_ANSI_ENABLED_MISMATCH
+ )
+ }
+ GenericExpressionTransformer(substraitExprName, children, expr)
+ }
+
+ override def genElementAtTransformer(
+ substraitExprName: String,
+ children: Seq[ExpressionTransformer],
+ expr: ElementAt): ExpressionTransformer = {
+ // Only the array input reads failOnError: Spark returns NULL for a key a
map does not
+ // contain whatever the ANSI mode is, and so does Velox.
+ if (expr.left.dataType.isInstanceOf[ArrayType]) {
+ if (expr.defaultValueOutOfBound.isDefined) {
+ GlutenExceptionUtil
+ .throwsNotFullySupported(
+ ExpressionNames.ELEMENT_AT,
+ ElementAtRestrictions.NOT_SUPPORT_DEFAULT_VALUE_OUT_OF_BOUND
+ )
+ }
+ // Velox derives whether an out-of-bound index raises an error from the
session's
+ // 'spark.sql.ansi.enabled', while Spark captures it in
ElementAt.failOnError at
+ // analysis time. The two normally agree; fall back when they don't.
+ if (expr.failOnError != SQLConf.get.ansiEnabled) {
+ GlutenExceptionUtil
+ .throwsNotFullySupported(
+ ExpressionNames.ELEMENT_AT,
+ ElementAtRestrictions.NOT_SUPPORT_FAIL_ON_ERROR_MISMATCH
Review Comment:
"Spark captures it in ElementAt.failOnError at analysis time", if Spark
already guarantees respecting ANSI when setting expression failOnError, do we
really need this check? Ditto for other functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
