anshulbaliga7 commented on PR #13137: URL: https://github.com/apache/gluten/pull/13137#issuecomment-5831492572
@yikf This completes the `FormatNumberRestrictions` you added in [#12754](https://github.com/apache/gluten/issues/12754). The restrictions were published in the generated function support docs but not enforced on the JVM side, so a decimal `format_number` only fell back via native validation with a generic reason. This routes `FormatNumber` through a backend hook, mirroring `str_to_map`, so the Velox backend rejects it up front with the documented message. Would appreciate a look when you have time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
