akshaytayal commented on code in PR #13126:
URL: https://github.com/apache/gluten/pull/13126#discussion_r4107899474
##########
.github/workflows/util/install-spark-resources.sh:
##########
@@ -122,6 +122,12 @@ if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
install_spark "4.1.1" "3" "2.12"
mv /opt/shims/spark41/spark_home/assembly/target/scala-2.12
/opt/shims/spark41/spark_home/assembly/target/scala-2.13
;;
+ 4.2)
+ # Spark-4.x, scala 2.12 // using 2.12 as a hack as 4.2 does not have a
2.13 suffix
+ cd ${INSTALL_DIR} && \
+ install_spark "4.2.0" "3" "2.12"
+ mv /opt/shims/spark42/spark_home/assembly/target/scala-2.12
/opt/shims/spark42/spark_home/assembly/target/scala-2.13
Review Comment:
Fixed in a931b25 . The mv now uses ${INSTALL_DIR} for both operands
instead of the hardcoded /opt , matching the cd ${INSTALL_DIR} and
install_spark calls just above — so a custom install root is honored. Default
/opt behavior is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
