Copilot commented on code in PR #13143:
URL: https://github.com/apache/gluten/pull/13143#discussion_r4110680755
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/transition/Transition.scala:
##########
@@ -93,11 +92,6 @@ object Transition {
}
}
Review Comment:
`Factory#satisfies` was a public method on the publicly exposed
`Transition.factory` (`Transition.factory` is not restricted and `Factory`
itself is public). Removing it can cause downstream Gluten extensions compiled
against the previous API to fail with a source/binary incompatibility even
though there are no in-repository callers. Please retain/deprecate this method
(and its `abort` fallback) or explicitly handle this as an API-breaking change
under the project’s release policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
