Copilot commented on code in PR #13150:
URL: https://github.com/apache/gluten/pull/13150#discussion_r4110751987
##########
gluten-core/src/test/scala/org/apache/spark/shuffle/ShuffleManagerRouterCacheSuite.scala:
##########
@@ -66,6 +67,21 @@ class ShuffleManagerRouterCacheSuite extends
SharedSparkSession {
assert(!gm.unregisterShuffle(neverRegistered))
}
+ test("block resolution of a never-registered shuffleId reports the shuffle
id") {
+ val gm = spark.sparkContext.env.shuffleManager
+ val resolver = gm.shuffleBlockResolver
+
+ val neverRegistered = 987654322
+ val exception = intercept[Exception] {
Review Comment:
This test intercepts the base `Exception`, so it does not verify the new
contract that a cache miss raises `GlutenException`; a regression to another
exception type could still pass if its message contains the id. Intercept
`GlutenException` directly, as the other Gluten exception tests do, so the test
covers both the diagnostic and the exception type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
