LuciferYang commented on code in PR #13098: URL: https://github.com/apache/gluten/pull/13098#discussion_r4130858738
########## gluten-core/src/main/scala/org/apache/spark/util/SparkDirectoryUtil.scala: ########## Review Comment: This follows Spark's own local-dir handling: a single root that fails to create is logged and skipped so the other roots still work, and we only fail when none survive. That all-failed case is where `namespace()` throws the clear `IllegalStateException`. Throwing on the first bad root would drop the multi-directory tolerance. If you would rather fail fast on any configured root that cannot be created, I am fine switching it, but I leaned toward matching Spark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
