akshaytayal opened a new issue, #13177: URL: https://github.com/apache/gluten/issues/13177
Part of the Spark 4.2 unit-test enablement (GLUTEN-12569, PR apache/gluten#13163). This issue tracks **re-enabling** one root-cause group of UTs that are currently **disabled** to keep the `gluten-ut/spark42` CI green. ### Root cause Golden-file drift on Spark 4.2 (TPC-DS plan-stability + SQLQueryTest .sql) ### How it's disabled TPC-DS plan-stability: `.exclude(...)` in `gluten-ut/spark42/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala`. GlutenSQLQueryTestSuite: the suite runs an **allowlist**, not the exclude registry, so the failing `.sql` files were **removed from `SUPPORTED_SQL_QUERY_LIST`/`OVERWRITE_SQL_QUERY_LIST`** in `gluten-ut/spark42/src/test/scala/org/apache/gluten/utils/velox/VeloxSQLQueryTestSettings.scala`. Two mechanisms: plan-stability via `.exclude`; `.sql` golden tests via allowlist removal. ### Files updated - `gluten-ut/spark42/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala` - `gluten-ut/spark42/src/test/scala/org/apache/gluten/utils/velox/VeloxSQLQueryTestSettings.scala` ### Disabled tests (46) - `GlutenTPCDSModifiedPlanStabilityWithStatsSuite` :: check simplified sf100 (tpcds-modifiedQueries/ss_max) - `GlutenTPCDSV1_4_PlanStabilityWithStatsSuite` :: check simplified sf100 (tpcds-v1.4/q16) - `GlutenTPCDSV1_4_PlanStabilityWithStatsSuite` :: check simplified sf100 (tpcds-v1.4/q28) - `GlutenTPCDSV1_4_PlanStabilityWithStatsSuite` :: check simplified sf100 (tpcds-v1.4/q5) - `GlutenTPCDSV1_4_PlanStabilityWithStatsSuite` :: check simplified sf100 (tpcds-v1.4/q54) - `GlutenTPCDSV1_4_PlanStabilityWithStatsSuite` :: check simplified sf100 (tpcds-v1.4/q94) - `GlutenTPCDSV1_4_PlanStabilityWithStatsSuite` :: check simplified sf100 (tpcds-v1.4/q95) - `GlutenTPCDSV1_4_PlanStabilitySuite` :: check simplified (tpcds-v1.4/q16) - `GlutenTPCDSV1_4_PlanStabilitySuite` :: check simplified (tpcds-v1.4/q28) - `GlutenTPCDSV1_4_PlanStabilitySuite` :: check simplified (tpcds-v1.4/q94) - `GlutenTPCDSV1_4_PlanStabilitySuite` :: check simplified (tpcds-v1.4/q95) - `GlutenTPCDSV2_7_PlanStabilityWithStatsSuite` :: check simplified sf100 (tpcds-v2.7.0/q5a) - `GlutenTPCDSV2_7_PlanStabilityWithStatsSuite` :: check simplified sf100 (tpcds-v2.7.0/q77a) - `GlutenTPCDSModifiedPlanStabilitySuite` :: check simplified (tpcds-modifiedQueries/ss_max) - `GlutenTPCDSV2_7_PlanStabilitySuite` :: check simplified (tpcds-v2.7.0/q77a) - `GlutenSQLQueryTestSuite(.sql)` :: charvarchar.sql - `GlutenSQLQueryTestSuite(.sql)` :: collations-basic.sql - `GlutenSQLQueryTestSuite(.sql)` :: collations-padding-trim.sql - `GlutenSQLQueryTestSuite(.sql)` :: collations-string-functions.sql - `GlutenSQLQueryTestSuite(.sql)` :: count.sql - `GlutenSQLQueryTestSuite(.sql)` :: cte-legacy.sql - `GlutenSQLQueryTestSuite(.sql)` :: cte-nested.sql - `GlutenSQLQueryTestSuite(.sql)` :: cte-nonlegacy.sql - `GlutenSQLQueryTestSuite(.sql)` :: cte-recursion.sql - `GlutenSQLQueryTestSuite(.sql)` :: cte.sql - `GlutenSQLQueryTestSuite(.sql)` :: double-quoted-identifiers.sql - `GlutenSQLQueryTestSuite(.sql)` :: grouping_set.sql - `GlutenSQLQueryTestSuite(.sql)` :: identifier-clause-legacy.sql - `GlutenSQLQueryTestSuite(.sql)` :: identifier-clause.sql - `GlutenSQLQueryTestSuite(.sql)` :: keywords.sql - `GlutenSQLQueryTestSuite(.sql)` :: kllquantiles.sql - `GlutenSQLQueryTestSuite(.sql)` :: nonansi/double-quoted-identifiers.sql - `GlutenSQLQueryTestSuite(.sql)` :: nonansi/keywords.sql - `GlutenSQLQueryTestSuite(.sql)` :: postgreSQL/create_view.sql - `GlutenSQLQueryTestSuite(.sql)` :: postgreSQL/float8.sql - `GlutenSQLQueryTestSuite(.sql)` :: postgreSQL/int4.sql - `GlutenSQLQueryTestSuite(.sql)` :: postgreSQL/int8.sql - `GlutenSQLQueryTestSuite(.sql)` :: postgreSQL/window_part2.sql - `GlutenSQLQueryTestSuite(.sql)` :: postgreSQL/window_part3.sql - `GlutenSQLQueryTestSuite(.sql)` :: postgreSQL/with.sql - `GlutenSQLQueryTestSuite(.sql)` :: show-create-table.sql - `GlutenSQLQueryTestSuite(.sql)` :: show-tables.sql - `GlutenSQLQueryTestSuite(.sql)` :: show_columns.sql - `GlutenSQLQueryTestSuite(.sql)` :: thetasketch.sql - `GlutenSQLQueryTestSuite(.sql)` :: try_aggregates.sql - `GlutenSQLQueryTestSuite(.sql)` :: union-resolution-edge-cases.sql ### How to re-enable Implement the underlying Gluten/Velox support, then remove the corresponding `.exclude(...)` / allowlist / `@Ignore` / `ignore(...)` entries and confirm the tests pass in the spark42 UT CI. Related: PR apache/gluten#13163, GLUTEN-12569. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
