akshaytayal commented on issue #13174: URL: https://github.com/apache/gluten/issues/13174#issuecomment-5946356209
Coverage follow-up (review #3): when re-enabling this suite, also fix `GlutenKeyGroupedPartitioningSuite.collectAllShuffles` — it currently overrides the inherited helper to return columnar-only (`ColumnarShuffleExchangeExec`), which hides vanilla fallback shuffles from inherited 'no shuffle remains' assertions (possible false-pass). Suggested: return `ShuffleExchangeLike` (both vanilla + columnar) and add a separate `collectAllColumnarShuffles` for the native-only checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
