rdtr opened a new pull request, #13188: URL: https://github.com/apache/gluten/pull/13188
## What changes are proposed in this pull request? `try_make_timestamp` and `try_make_timestamp_ltz` become `MakeTimestamp` with `failOnError = false`, which returns NULL for invalid input even in ANSI mode. Gluten mapped every `MakeTimestamp` to Velox's `make_timestamp`, which throws when ANSI mode is enabled, so with `spark.gluten.sql.ansiFallback.enabled=false` these functions threw instead of returning NULL. This PR maps `MakeTimestamp` with `failOnError = false` and a TIMESTAMP result to Velox's `try_make_timestamp`, which never throws for invalid input. Velox registers `try_make_timestamp` for TIMESTAMP results only, so TIMESTAMP_NTZ results keep the current mapping. Related issue: #10134 (TryMakeTimestampLTZExpressionBuilder) ## How was this patch tested? Added a test to `ArithmeticAnsiValidateSuite` (ANSI mode on, ANSI fallback off, Spark 4.0+): `try_make_timestamp` and `try_make_timestamp_ltz` return NULL for an invalid month and run in Velox, while `make_timestamp` still throws. Passed on Spark 4.1. Without the change, the new test fails. ## Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
