ReemaAlzaid opened a new pull request, #13190:
URL: https://github.com/apache/gluten/pull/13190
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid
duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR
title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
## What changes are proposed in this pull request?
<!--
Provide a clear and concise description of the changes introduced in this PR.
Ensure the PR description aligns with the code changes, especially after
updates.
If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the
corresponding issue
when the PR is merged.
-->
Fix cast-mode selection when converting aggregate intermediate states
between Spark and Velox.
The cast builder’s boolean argument means `isTryCast`, but these callers
passed `ansiEnabled`. This generated ANSI casts when ANSI was disabled and TRY
casts when it was enabled.
Use explicit `LEGACY` or `ANSI` modes in both conversion directions.
Related to #10134. Discovered while investigating #13122.
This fixes cast-mode selection, not aggregate overflow checking.
## How was this patch tested?
<!--
Describe how the changes were tested, if applicable.
Include new tests to validate the functionality, if necessary.
For UI-related changes, attach screenshots to demonstrate the updates.
-->
- Added six regression tests covering Partial, PartialMerge, and Final
aggregation with ANSI enabled and disabled. All fail before the fix and pass
afterward.
- Compared aggregate results against vanilla Spark.
- Existing regular and flushable aggregate suites pass.
- Formatting and license-header checks pass.
-
## Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Generated-PR-Description : Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
