HwangDongJun commented on PR #12833: URL: https://github.com/apache/gluten/pull/12833#issuecomment-6028914049
@zhouyuan — infvg's account was deleted, so all of infvg's review comments on this thread are gone, including the ones my Sep 30 replies were responding to. The history is broken in the middle, so re-posting what happened: infvg had pointed out that deriving root paths from table metadata (write.data.path, etc.) could miss files left at their old location if that property gets changed later, and suggested deriving the paths from the actual planned scan tasks instead. I implemented that, and verified it doesn't bring back the DPP regression from earlier — TestGlutenRuntimeFiltering still passes 18/18. Let me know if anything's unclear now that the original comments are gone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
