jackylee-ch commented on PR #13144: URL: https://github.com/apache/gluten/pull/13144#issuecomment-6116617625
Thanks for the rework — moving selfTime to an nsTiming metric is the right shape and the code is clean. I'm going to close this one, though: selfTime on a columnar-to-columnar node is a cosmetic UI metric, and as you noted there's no case where its near-zero reading actually misled anyone. It isn't worth the review and maintenance surface right now. Happy to reopen if a concrete case of diagnosing C2C transition cost turns up that needs it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
