pratham76 commented on code in PR #13250:
URL: https://github.com/apache/gluten/pull/13250#discussion_r4246878554
##########
gluten-substrait/src/test/scala/org/apache/spark/sql/WithQueryPlanListener.scala:
##########
@@ -53,6 +53,8 @@ trait WithQueryPlanListener extends SharedSparkSession with
AnyFunSuiteLike {
pos: Position): Unit = {
super.test(testName, testTags: _*) {
testFun
+ // Query execution listeners are notified asynchronously; wait for all
the plans.
Review Comment:
`afterEach` unregisters the listener without first calling
`waitUntilEmpty()`.
Spark's AsyncEventQueue doesn't interrupt in-flight dispatch on unregister,
so this is unlikely to bite in practice, but adding `waitUntilEmpty()` before
the `unregister` calls in `afterEach` would make the teardown consistent with
this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
