rdtr opened a new pull request, #13262:
URL: https://github.com/apache/gluten/pull/13262

   ## What changes are proposed in this pull request?
   
   Fixes 2 more Spark 4.2 tests in #13179 that #13163 disabled. This is a 
test-only change.
   
   - `GlutenSessionExtensionSuite` "Gluten - test gluten extensions": since 
SPARK-55964, function identifiers in the function registry are fully qualified, 
and functions injected through `SparkSessionExtensions` are registered as 
builtin functions (`system.builtin.<name>`). The test looked up the injected 
function by its unqualified name and failed with "Function identifier must be 
fully qualified (3-part)". It now looks it up with the 3-part name, as Spark 
4.2's `SparkSessionExtensionSuite` does, and the exclude is removed.
   - `GlutenResolveDefaultColumnsSuite` "SPARK-57187: non-foldable default 
exceeding CHAR/VARCHAR length fails at INSERT time (explicit DEFAULT keyword)": 
the test expects a `SparkRuntimeException` with `EXCEED_LIMIT_LENGTH`. In 
Gluten, Velox runs the write-side length check and the error is a 
`SparkException` with Velox's message ("Exceeds allowed length limitation: 1"). 
The original test stays excluded, and a Gluten version accepts either error, 
the same way `GlutenCharVarcharTestSuite.assertLengthCheckFailure` does.
   
   Part of #13179.
   
   ## How was this patch tested?
   
   The changed tests compile on Spark 4.2. The Spark 4.2 UT CI runs them.
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5.5)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to