malinjawi commented on PR #13042: URL: https://github.com/apache/gluten/pull/13042#issuecomment-6142599241
> @felipepessoto thanks for the patch. @malinjawi Could we support DV read in this case like (#12836)? @zhouyuan Not with #12836 alone that PR only moved DV loading to the executors, and native reads still work by dropping deleted rows. The scans in this PR need the actual row index and deleted-row flag as values, which Velox can't produce yet. We would need to add that natively so I'd land this one first as the correctness fix and build on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
