Copilot commented on code in PR #13103: URL: https://github.com/apache/gluten/pull/13103#discussion_r4269878743
########## ep/build-velox/src/get-velox.sh: ########## @@ -25,7 +25,7 @@ RUN_SETUP_SCRIPT=ON ENABLE_ENHANCED_FEATURES=OFF # Developer use only for testing Velox PR. -UPSTREAM_VELOX_PR_ID="" +UPSTREAM_VELOX_PR_ID="19141" Review Comment: Hardcoding `UPSTREAM_VELOX_PR_ID` to a specific PR id will make all builds fetch/test against that upstream PR by default, which is risky for normal CI and developer workflows. This should remain empty by default (or be set via an environment variable / explicit opt-in flag), matching the PR description that the hook is temporary and not intended to merge as a default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
