sabbasani opened a new pull request, #13326:
URL: https://github.com/apache/gluten/pull/13326
…d match keys case-sensitively
Spark's from_json matches JSON keys against schema field names
case-sensitively, regardless of spark.sql.caseSensitive.
- Add FromJsonTransformer, which builds the output struct type without
lowercasing field names (including nested ones) via a new
ConverterUtils.getTypeNode overload. Used by Velox and Bolt.
- Velox: drop the caseSensitive=true fallback and fall back only for exactly
equal field names. Carry a Velox patch (applied by get-velox.sh) so
FromJson.cpp matches exactly and checkColumnNameLowerCase ignores computed
expression types.
- Bolt: field names now reach the native side unchanged; its existing
fallbacks are kept.
- Add FromJsonCaseSensitivitySuite (64 tests, both caseSensitive modes,
compared with vanilla Spark, native execution asserted) and Bolt tests.
Fixes #13251
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid
duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR
title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
## What changes are proposed in this pull request?
<!--
Provide a clear and concise description of the changes introduced in this PR.
Ensure the PR description aligns with the code changes, especially after
updates.
If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the
corresponding issue
when the PR is merged.
-->
## How was this patch tested?
<!--
Describe how the changes were tested, if applicable.
Include new tests to validate the functionality, if necessary.
For UI-related changes, attach screenshots to demonstrate the updates.
-->
## Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
