This is an automated email from the ASF dual-hosted git repository.
philo-he pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gluten.git
The following commit(s) were added to refs/heads/main by this push:
new a256c51083 [MINOR][INFRA] Use the CI license header check instead of
dev/check.py header (#13339)
a256c51083 is described below
commit a256c510832206e7d3ddb3223139d3412a7f2664
Author: Mohammad Linjawi <[email protected]>
AuthorDate: Sat Oct 17 01:27:42 2026 +0300
[MINOR][INFRA] Use the CI license header check instead of dev/check.py
header (#13339)
---
AGENTS.md | 2 +-
CONTRIBUTING.md | 2 +-
dev/check.py | 26 +++++---------------------
docs/developers/HowToRelease.md | 2 +-
4 files changed, 8 insertions(+), 24 deletions(-)
diff --git a/AGENTS.md b/AGENTS.md
index 3227f55f2d..3596d5276c 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -97,7 +97,7 @@ You MUST run the following checks and fix any issues before
committing.
```bash
# Requires the `regex` Python package: pip install regex
-./dev/check.py header main --fix
+./.github/workflows/util/check.py header main --fix
```
Do not commit code that fails CI checks.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 8aa3d26814..94ab8e081d 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -63,7 +63,7 @@ An identical license header is used for all Gluten source
code. If lacked or wro
You can execute a script to fix license header issue, as the following shows.
-`dev/check.py header main --fix`
+`.github/workflows/util/check.py header main --fix`
### Gluten CI
diff --git a/dev/check.py b/dev/check.py
index 89b7a9155d..fe01cb5404 100755
--- a/dev/check.py
+++ b/dev/check.py
@@ -154,19 +154,6 @@ def format_command(commit, files, fix):
return ok
-def header_command(commit, files, fix):
- options = "-vk" if fix == "show" else "-i"
-
- status, stdout, stderr = util.run(
- f"{SCRIPTS}/license-header.py {options} -", input=files
- )
-
- if stdout != "":
- print(stdout)
-
- return status
-
-
def tidy_command(commit, files, fix):
files = [file for file in files if regex.match(r".*\.(cc|cpp|h)$", file)]
@@ -256,17 +243,18 @@ def parse_args():
global parser
parser = argparse.ArgumentParser(
formatter_class=argparse.RawTextHelpFormatter,
- description="""Check format/header/tidy
+ description="""Check format/tidy
- check.py {format,header,tidy} {commit,branch} [--fix]
- check.py {format,header,tidy} {tree} [--fix] PATH
+ check.py {format,tidy} {commit,branch} [--fix]
+ check.py {format,tidy} {tree} [--fix] PATH
+
+License headers are checked by .github/workflows/util/check.py.
""",
)
command = parser.add_subparsers(dest="command")
command.add_parser("help")
format_command_parser = add_check_command(command, "format")
- header_command_parser = add_check_command(command, "header")
tidy_command_parser = add_check_command(command, "tidy")
parser.set_defaults(path="")
@@ -286,10 +274,6 @@ def format(args):
return run_command(args, format_command)
-def header(args):
- return run_command(args, header_command)
-
-
def tidy(args):
return run_command(args, tidy_command)
diff --git a/docs/developers/HowToRelease.md b/docs/developers/HowToRelease.md
index 249dde1717..fe5c60ec5a 100644
--- a/docs/developers/HowToRelease.md
+++ b/docs/developers/HowToRelease.md
@@ -74,7 +74,7 @@ being added to `NOTICE-binary`.
```bash
# Requires the `regex` Python package: pip install regex
-python3 dev/check.py header main
+python3 .github/workflows/util/check.py header main
```
Reviewers also run [Apache RAT](https://creadur.apache.org/rat/) against the
source archive. Note
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
