Copilot commented on code in PR #13168: URL: https://github.com/apache/gluten/pull/13168#discussion_r4301349822
########## cpp/core/CMakeLists.txt: ########## @@ -251,11 +254,12 @@ if(BUILD_TESTS) add_subdirectory(tests) endif() -target_link_libraries(gluten PUBLIC Arrow::arrow) +target_link_libraries(gluten_core_impl PUBLIC Arrow::arrow) if(NOT ENABLE_GLUTEN_VCPKG) - target_link_libraries(gluten PUBLIC Arrow::arrow_bundled_dependencies) + target_link_libraries(gluten_core_impl + PUBLIC Arrow::arrow_bundled_dependencies) endif() -target_link_libraries(gluten PRIVATE glog::glog) +target_link_libraries(gluten_core_impl PRIVATE glog::glog) Review Comment: `JniWrapper.cc` includes `compute/Runtime.h`, which includes `<glog/logging.h>`. Moving glog to a PRIVATE dependency of `gluten_core_impl` means its include directories and compile definitions no longer reach the `gluten` target that compiles the wrapper. Builds with glog in a separate prefix (for example, selected through `glog_DIR`) can therefore fail compiling the JNI facade. Make this dependency PUBLIC so the facade and other consumers of the core headers receive glog's compile requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
