zhztheplayer commented on code in PR #13346:
URL: https://github.com/apache/gluten/pull/13346#discussion_r4314939632
##########
cpp/velox/operators/plannodes/RowVectorStream.cc:
##########
@@ -136,47 +136,50 @@ void
ValueStreamDataSource::addSplit(std::shared_ptr<facebook::velox::connector:
std::optional<facebook::velox::RowVectorPtr> ValueStreamDataSource::next(
uint64_t size,
facebook::velox::ContinueFuture& future) {
- // Try to get current iterator if we don't have one
- while (!currentIterator_) {
- if (pendingIterators_.empty()) {
- // No more iterators to process
- return nullptr;
- }
-
- // Get next RowVectorStream from queue
- currentIterator_ = pendingIterators_.front();
- pendingIterators_.erase(pendingIterators_.begin());
- }
-
- // Check if current stream has more data
- if (!currentIterator_->hasNext()) {
- // Current stream exhausted, try next one
- currentIterator_ = nullptr;
- return next(size, future); // Recursively try next stream
- }
-
- // Get next batch from current stream (RowVectorStream handles conversion)
- auto rowVector = currentIterator_->next();
+ for (;;) {
+ // Try to get current iterator if we don't have one.
+ while (!currentIterator_) {
Review Comment:
```suggestion
if (!currentIterator_) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
