maoyuwei1 commented on PR #13283: URL: https://github.com/apache/gluten/pull/13283#issuecomment-6285181717
Added CelebornShuffleManagerTest, which drives initializeLifecycleManager() and stop() and asserts the manager retains the FailedShuffleCleaner (L182-183) and that stop() shuts down its executor and clears the field (L283-285). The cleaner is always released in a finally block. It’s hermetic: LifecycleManager construction and ShuffleClient are mocked, so there is no RpcEnv, no ApplicationHeartbeater and no RPC against a Celeborn master. SparkConf(false) ignores ambient spark.* properties, and the cleanup interval is 1h so the periodic task never fires. The only static stubbed out is Celeborn’s SparkUtils.addSparkListener(), which dereferences SparkContext.getActive() without a null check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
