This is an automated email from the ASF dual-hosted git repository.
rui-mo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gluten.git
The following commit(s) were added to refs/heads/main by this push:
new ea08752e65 [GLUTEN-13175][VL] Re-enable the Spark 4.2 DELETE tests in
GlutenDeleteFromTableSuite (#13316)
ea08752e65 is described below
commit ea08752e653acba49c417fee9e99592dd61f4c9a
Author: Akshay Tayal <[email protected]>
AuthorDate: Tue Oct 20 11:27:43 2026 -0700
[GLUTEN-13175][VL] Re-enable the Spark 4.2 DELETE tests in
GlutenDeleteFromTableSuite (#13316)
---
.../gluten/utils/velox/VeloxTestSettings.scala | 26 ----------------------
.../GlutenGroupBasedDeleteFromTableSuite.scala | 10 ++++++++-
2 files changed, 9 insertions(+), 27 deletions(-)
diff --git
a/gluten-ut/spark42/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
b/gluten-ut/spark42/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index 21bda74ea2..419762076b 100644
---
a/gluten-ut/spark42/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++
b/gluten-ut/spark42/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -77,32 +77,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("partitioning reporting")
.exclude("ordering and partitioning reporting")
enableSuite[GlutenDeleteFromTableSuite]
- .exclude("delete from empty tables") // GLUTEN-12569 Spark 4.2 UT
enablement (CI-confirmed)
- .exclude(
- "delete from table with table constraints"
- ) // GLUTEN-12569 Spark 4.2 UT enablement (CI-confirmed)
- .exclude("delete with EXISTS subquery") // GLUTEN-12569 Spark 4.2 UT
enablement (CI-confirmed)
- .exclude(
- "delete with NOT EXISTS subquery"
- ) // GLUTEN-12569 Spark 4.2 UT enablement (CI-confirmed)
- .exclude("delete with NOT IN predicates") // GLUTEN-12569 Spark 4.2 UT
enablement (CI-confirmed)
- .exclude("delete with NOT IN subqueries") // GLUTEN-12569 Spark 4.2 UT
enablement (CI-confirmed)
- .exclude(
- "delete with NULL condition on non-null column"
- ) // GLUTEN-12569 Spark 4.2 UT enablement (CI-confirmed)
- .exclude(
- "delete with NULL equality on VOID column"
- ) // GLUTEN-12569 Spark 4.2 UT enablement (CI-confirmed)
- .exclude("delete with aliases") // GLUTEN-12569 Spark 4.2 UT enablement
(CI-confirmed)
- .exclude(
- "delete with conditions on nested columns"
- ) // GLUTEN-12569 Spark 4.2 UT enablement (CI-confirmed)
- .exclude(
- "delete with literal false condition"
- ) // GLUTEN-12569 Spark 4.2 UT enablement (CI-confirmed)
- .exclude(
- "delete with unsupported predicates cannot be converted into delete with
filters"
- ) // GLUTEN-12569 Spark 4.2 UT enablement (CI-confirmed)
enableSuite[GlutenFileDataSourceV2FallBackSuite]
// Rewritten
.exclude("Fallback Parquet V2 to V1")
diff --git
a/gluten-ut/spark42/src/test/scala/org/apache/spark/sql/connector/GlutenGroupBasedDeleteFromTableSuite.scala
b/gluten-ut/spark42/src/test/scala/org/apache/spark/sql/connector/GlutenGroupBasedDeleteFromTableSuite.scala
index 5e9abeb077..00363609a0 100644
---
a/gluten-ut/spark42/src/test/scala/org/apache/spark/sql/connector/GlutenGroupBasedDeleteFromTableSuite.scala
+++
b/gluten-ut/spark42/src/test/scala/org/apache/spark/sql/connector/GlutenGroupBasedDeleteFromTableSuite.scala
@@ -16,6 +16,7 @@
*/
package org.apache.spark.sql.connector
+import org.apache.spark.SparkConf
import org.apache.spark.sql.GlutenSQLTestsBaseTrait
class GlutenGroupBasedDeleteFromTableSuite
@@ -24,4 +25,11 @@ class GlutenGroupBasedDeleteFromTableSuite
class GlutenDeleteFromTableSuite
extends GroupBasedDeleteFromTableSuite
- with GlutenSQLTestsBaseTrait {}
+ with GlutenSQLTestsBaseTrait {
+ // Spark's own tests use 5 shuffle partitions. With 1, the write's
clustering by _partition is a
+ // SinglePartition shuffle, so AQE may replace the input of ReplaceDataExec
with an EmptyRelation
+ // when no rows are copied. That hides the scan used to compute
numDeletedRows, which becomes -1.
+ override def sparkConf: SparkConf = {
+ super.sparkConf.set("spark.sql.shuffle.partitions", "5")
+ }
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
