ReemaAlzaid commented on code in PR #13236:
URL: https://github.com/apache/gluten/pull/13236#discussion_r4328979613
##########
cpp/velox/compute/VeloxPlanConverter.cc:
##########
@@ -270,9 +273,13 @@ void parseLocalFileNodes(
std::shared_ptr<const facebook::velox::core::PlanNode>
VeloxPlanConverter::toVeloxPlan(
const ::substrait::Plan& substraitPlan,
- std::vector<::substrait::ReadRel_LocalFiles> localFiles) {
+ std::vector<::substrait::ReadRel_LocalFiles> localFiles,
+ std::vector<std::string> rawSplitInfos) {
if (!validationMode_) {
- parseLocalFileNodes(&substraitVeloxPlanConverter_, veloxCfg_, localFiles);
+ if (rawSplitInfos.empty()) {
+ parseLocalFileNodes(&substraitVeloxPlanConverter_, veloxCfg_,
localFiles);
+ }
+ substraitVeloxPlanConverter_.setRawSplitInfos(std::move(rawSplitInfos));
Review Comment:
Added a comment here explaining the split order and how the decoded splits
are passed to the converter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
