akshaytayal opened a new pull request, #13437: URL: https://github.com/apache/gluten/pull/13437
## What changes are proposed in this pull request? Re-enables three Spark 4.2 tests that #13163 disabled. This is a test-only change. - `GlutenMathFunctionsSuite` `acosh` and `GlutenMathExpressionsSuite` `SPARK-56089: asinh/acosh fdlibm algorithm coverage`: for out-of-domain inputs both Spark and Velox return NaN, but with different bit patterns (Spark 4.2 returns the canonical `Double.NaN`; Velox's `std::acosh` returns the x86 negative quiet NaN). Gluten's shared result comparison (`GlutenQueryTestUtil.compare`, `GlutenTestsTrait.checkResult`) compared NaN bit for bit, which is stricter than Spark's own test helpers. Both now treat any two NaN values as equal. The `0.0` vs `-0.0` check and the tolerance for other values are unchanged. - `GlutenXmlExpressionsSuite` `TIME type with arrays`: Gluten falls back to Spark for the TIME type, but Gluten's expression test harness collects results through `Dataset.collect()`, which can't deserialize `ARRAY<TIME(p)>` with `p < 6` (`CANNOT_UP_CAST_DATATYPE`). The original test stays excluded and a Gluten version evaluates the same expressions and checks the internal rows against the same expected values. `TruncTimestamp of Long.MinValue overflows with ArithmeticException` stays disabled; it needs a Velox change (#13436). Part of #13178 (umbrella #13181). ## How was this patch tested? Locally on Spark 4.2: `GlutenMathFunctionsSuite`, `GlutenMathExpressionsSuite`, `GlutenXmlExpressionsSuite` and `GlutenDateExpressionsSuite`: 219 succeeded, 0 failed. CI covers the other Spark versions. ## Was this patch authored or co-authored using generative AI tooling? Generated-by: GitHub Copilot CLI (Claude Opus 5.5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
