akshaytayal opened a new pull request, #13442:
URL: https://github.com/apache/gluten/pull/13442

   ## What changes are proposed in this pull request?
   
   Re-enables three Spark 4.2 tests that #13163 disabled. This is a test-only 
change.
   
   - `GlutenSessionExtensionSuite` `Gluten - test gluten extensions`: Spark 
4.2's `SimpleFunctionRegistry` requires fully qualified identifiers and stores 
injected extension functions under `system.builtin.<name>`. Look the function 
up with `FunctionRegistry.builtinFunctionIdentifier`, as Spark's own 
`SparkSessionExtensionSuite` does.
   - `GlutenResolveDefaultColumnsSuite` `SPARK-57187: non-foldable default 
exceeding CHAR/VARCHAR length fails at INSERT time (explicit DEFAULT keyword)`: 
the CHAR/VARCHAR length check runs natively, so the INSERT fails with Velox's 
`Exceeds allowed length limitation` error wrapped in a `SparkException` instead 
of Spark's `SparkRuntimeException` (`EXCEED_LIMIT_LENGTH`). The parent test is 
excluded and a Gluten version runs the same statements and checks the native 
error.
   - `GlutenDataFrameSuite` `SPARK-57725: resolve columns when the input plan 
has a null-named attribute` already passes since #13206; the stale exclude is 
removed.
   
   `MiscOperatorSuite` / `GlutenBloomFilterFallbackSuite` (also #13179) are 
covered by #13195.
   
   Part of #13179 (umbrella #13181).
   
   ## How was this patch tested?
   
   Locally on Spark 4.2: `GlutenSessionExtensionSuite`, 
`GlutenResolveDefaultColumnsSuite` and `GlutenDataFrameSuite`: 194 succeeded, 0 
failed.
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: GitHub Copilot CLI (Claude Opus 5.5)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to