FelixYBW commented on code in PR #13421:
URL: https://github.com/apache/gluten/pull/13421#discussion_r4370158220


##########
.github/workflows/iceberg_spark_ut.yml:
##########
@@ -15,43 +15,14 @@
 
 name: Iceberg Spark UT (Gluten)
 
+# Pull requests run this from velox_backend_x86.yml, which passes the static 
native libraries
+# it already built for the head revision. Manual runs build them here.
 on:
-  pull_request:
-    paths:
-      - '.github/workflows/iceberg_spark_ut.yml'
-      - '.github/workflows/iceberg_upstream_revision.yml'
-      - '.github/workflows/velox_native_build.yml'
-      - '.github/workflows/util/iceberg-upstream/**'
-      - 'backends-velox/src-iceberg*/**'
-      - 'gluten-iceberg/**'
-      - 'gluten-ut/src-iceberg-upstream/**'
-      # Shared production code and dependencies used by Iceberg on Spark 3.5.
-      - 'pom.xml'
-      - 'backends-velox/pom.xml'
-      - 'backends-velox/src/main/**'
-      - 'gluten-core/pom.xml'
-      - 'gluten-core/src/main/**'
-      - 'gluten-substrait/pom.xml'
-      - 'gluten-substrait/src/main/**'
-      - 'gluten-arrow/pom.xml'
-      - 'gluten-arrow/src/main/**'
-      - 'shims/pom.xml'
-      - 'shims/common/pom.xml'
-      - 'shims/common/src/main/**'
-      - 'shims/spark35/pom.xml'
-      - 'shims/spark35/src/main/**'
-      - 'build/mvn'
-      - 'dev/gluten-build-info.sh'
-      # Native code and the build inputs used by velox_native_build.yml.
-      - 'cpp/**'
-      - 'ep/build-velox/**'
-      - 'dev/ci-velox-buildstatic-centos-8.sh'
-      - 'dev/builddeps-veloxbe.sh'
-      - 'dev/build-helper-functions.sh'
-      - 'dev/vcpkg/**'
-      # Documentation-only changes do not affect this runtime.
-      - '!**/*.md'
-      - '!**/*.rst'
+  workflow_call:

Review Comment:
   why iceberg CI needs to wait until static build finish, right? or anything 
else to wait?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to