malinjawi commented on PR #13165:
URL: https://github.com/apache/gluten/pull/13165#issuecomment-6414714080
> The initial estimate when I ran the CI with increment metric offload
disabled was fixing 225 tests. The PR removed only 179, do you know if it is
because my baseline became stale after Delta 4.4 update? Or do we still have
some cases to fix?
>
> In my experiment disabling the offload it would also avoid some other
unrelated bugs
Good question @felipepessoto
Its not the Delta 4.4 update. Out of your 225:
- 157 are removed in this PR
- 54 were already fixed on main by #13198 (I dropped them from the baseline
in #13252)
- 14 still fail, all MergeIntoNestedStructInMapEvolution. With offload
disabled that projection runs on Spark, but here it stays in Velox, and Velox's
transform_keys rejects map keys with a null field ("map key cannot be
indeterminate"). That happens when schema evolution adds a field to a struct
map key. Spark is fine with it, so it's one of those unrelated bugs. I'll
follow up on it separately.
This PR also drops 22 that weren't in your list (20 ImplicitMergeCasting
overflow tests and the 2 no-op MERGE CDC stream tests), which is how it gets to
179.
Do you think there is a mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
