luis4a0 commented on PR #13103: URL: https://github.com/apache/gluten/pull/13103#issuecomment-6468008088
I checked the remaining automated review concerns against the current source: - `validateRound` is private and called from `validateScalarFunction`, which constructs exactly one converted parameter per Substrait argument before dispatch. The existing argument-count check rejects fewer than two arguments before `params[0]` is accessed. There is no caller passing an independently sized parameter vector; the proposed size-mismatch scenario does not occur on this path. - Evaluating a foldable scale is intentional. Its evaluation errors must propagate rather than be swallowed during planning. The JVM regression explicitly checks an invalid foldable INTEGER cast, while other cases cover bounded foldable expressions and typed NULL with native validation disabled. - The validator deliberately combines the converted value type with the serialized scale literal: the former handles nontrivial input expressions; the latter checks the constant scale represented in the native plan. - The common test source still supports Scala 2.12 profiles, so its existing `JavaConverters` import is retained rather than replacing it with a Scala-2.13-only API. - The developer dependency hook remains an explicit merge gate, as already agreed in review. It will not be treated as merge-ready before a qualified normal Velox dependency includes the upstream change. The companion's current CI is green, but the native PR now has a further reviewed identity-copy/documentation revision: https://github.com/facebookincubator/velox/commit/ef41496a1488afa1b811247cc303e8047cba5d33 Could a maintainer rerun this companion's CI against that updated native head after approving the Velox workflows? The existing green result qualified the previous native revision, not the new one. I cannot rerun upstream workflows with my current repository permissions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
