luis4a0 commented on PR #13282: URL: https://github.com/apache/gluten/pull/13282#issuecomment-6468008552
I also checked the remaining automated review concerns: - `validateRound` is private; its only caller constructs one converted parameter per Substrait argument before dispatch. The existing fewer-than-two-arguments check runs before accessing `params[0]`, so the suggested independently sized parameter vector is not a reachable caller state. - The JVM eligibility check is intentionally keyed to Spark's `Round` expression and its integral child type. It preserves the captured Spark semantics even when general native validation is disabled; another textual native function name must not bypass that safeguard. - The overflow regression intentionally checks a Velox user error containing the ROUND-specific overflow message, not just any exception that could also indicate a missing registration or invalid signature. - `PS` is already defined as Partial Support in the operator-support document's legend. - The documented compatibility limits and temporary upstream-PR dependency hook remain intentional and are not waived for merge. Native landing plus a qualified normal dependency are still required. No additional arithmetic or fallback changes were needed for these comments. The separately reported streaming CI failure still needs the maintainer rerun requested above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
