This is an automated email from the ASF dual-hosted git repository.
zhztheplayer pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gluten.git
The following commit(s) were added to refs/heads/main by this push:
new d201676138 [GLUTEN-13275][VL] Check out the PR in the ANSI workflow
test jobs (#13371)
d201676138 is described below
commit d20167613814d11286fe32a9dbce1569fe8c6909
Author: rdtr <[email protected]>
AuthorDate: Wed Oct 28 12:43:35 2026 -0700
[GLUTEN-13275][VL] Check out the PR in the ANSI workflow test jobs (#13371)
The test jobs in the ANSI workflow check out
needs.check-comment.outputs.pr_sha, but they only list build-native-lib in
needs. The needs context only has the outputs of direct dependencies, so pr_sha
is empty, and actions/checkout falls back to the default branch for an
issue_comment event. So the tests ran the code of main, while the native
library was built from the PR.
List check-comment in needs of the four test jobs.
---
.github/workflows/velox_backend_ansi.yml | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/.github/workflows/velox_backend_ansi.yml
b/.github/workflows/velox_backend_ansi.yml
index 99b0df36b0..9a254da175 100644
--- a/.github/workflows/velox_backend_ansi.yml
+++ b/.github/workflows/velox_backend_ansi.yml
@@ -150,7 +150,8 @@ jobs:
if-no-files-found: error
spark-test-backends-velox-ansi41:
- needs: build-native-lib
+ # Lists check-comment directly so that needs.check-comment.outputs.pr_sha
is set.
+ needs: [check-comment, build-native-lib]
runs-on: ubuntu-22.04
env:
SPARK_TESTING: true
@@ -218,7 +219,8 @@ jobs:
**/target/*.log
spark-test-spark-ut-ansi41:
- needs: build-native-lib
+ # Lists check-comment directly so that needs.check-comment.outputs.pr_sha
is set.
+ needs: [check-comment, build-native-lib]
runs-on: ubuntu-22.04
env:
SPARK_TESTING: true
@@ -296,7 +298,8 @@ jobs:
**/gluten-ut/**/core.*
spark-test-backends-velox-ansi-spark40:
- needs: build-native-lib
+ # Lists check-comment directly so that needs.check-comment.outputs.pr_sha
is set.
+ needs: [check-comment, build-native-lib]
runs-on: ubuntu-22.04
env:
SPARK_TESTING: true
@@ -364,7 +367,8 @@ jobs:
**/target/*.log
spark-test-spark-ut-ansi-spark40:
- needs: build-native-lib
+ # Lists check-comment directly so that needs.check-comment.outputs.pr_sha
is set.
+ needs: [check-comment, build-native-lib]
runs-on: ubuntu-22.04
env:
SPARK_TESTING: true
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
