rui-mo commented on code in PR #12963:
URL: https://github.com/apache/gluten/pull/12963#discussion_r4406336110
##########
docs/backends/velox/velox-backend-support-progress.md:
##########
@@ -55,7 +57,7 @@ Gluten supports 30+ operators (Drag to right to see all data
types)
| | The unnest operation expands arrays and maps
into separate columns
| N
| UnnestNode | NS | NS | NS | NS
| NS | NS | NS | NS | NS | NS | NS | NS | NS |
NS | NS | NS | NS | NS |
| | The top-n operation reorders a dataset based
on one or more identified sort fields as well as a sorting order
| N
| TopNNode | NS | NS | NS | NS
| NS | NS | NS | NS | NS | NS | NS | NS | NS |
NS | NS | NS | NS | NS |
| | The partitioned output operation redistributes
data based on zero or more distribution fields
| N
| PartitionedOutputNode | NS | NS | NS | NS |
NS | NS | NS | NS | NS | NS | NS | NS | NS | NS
| NS | NS | NS | NS |
-| | The values operation returns specified data
| N
| ValuesNode | NS | NS | NS | NS |
NS | NS | NS | NS | NS | NS | NS | NS | NS | NS
| NS | NS | NS | NS |
+| OneRowRelationExec (4.1+) | Produces one zero-column row for queries
without an input relation
|
OneRowRelationExecTransformer | TableScanNode
(iterator connector) | | | | | | | |
| | | | | | | | |
| |
Review Comment:
**[Suggestion]** Keep the existing ValuesNode row in the operator map
The new `OneRowRelationExec` row replaces the existing Velox `ValuesNode`
row instead of being added next to it, which deletes unrelated operator
documentation. Restore the `ValuesNode` row and insert the new row separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]