wud-if commented on code in PR #13412: URL: https://github.com/apache/gluten/pull/13412#discussion_r4411811805
########## gluten-flink/ut/src/test/java/org/apache/gluten/rexnode/functions/RexCallConverterFactoryTest.java: ########## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gluten.rexnode.functions; + +import org.apache.gluten.rexnode.RexConversionContext; + +import io.github.zhztheplayer.velox4j.expression.CallTypedExpr; +import io.github.zhztheplayer.velox4j.expression.CastTypedExpr; +import io.github.zhztheplayer.velox4j.expression.TypedExpr; + +import org.apache.flink.table.planner.calcite.FlinkRexBuilder; +import org.apache.flink.table.planner.calcite.FlinkTypeFactory; +import org.apache.flink.table.planner.calcite.FlinkTypeSystem; +import org.apache.flink.table.planner.functions.sql.FlinkSqlOperatorTable; + +import org.apache.calcite.rex.RexBuilder; +import org.apache.calcite.rex.RexCall; +import org.apache.calcite.rex.RexLiteral; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.sql.SqlFunction; +import org.apache.calcite.sql.SqlFunctionCategory; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.calcite.sql.type.OperandTypes; +import org.apache.calcite.sql.type.ReturnTypes; +import org.apache.calcite.sql.type.SqlTypeName; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; + +import java.math.BigDecimal; +import java.util.Collections; + +import static org.assertj.core.api.Assertions.assertThat; + +public class RexCallConverterFactoryTest { Review Comment: Thanks for the review! The dual-run queries are now embedded verbatim as tests: ArithmeticDualRunSqlTest (52c62f5) carries the exact SELECT statements — VALUES sources included — that ran on Flink 1.19.2 in the dual-run (native vs gluten-offloaded, identical inputs, exact changelog-multiset comparison), with the native output rows they matched against; testAbsIntegerBoundaries / testRoundHalfUpTieInDecimalDomain additionally pin the INT_MIN / int64-min wraparounds and the 2.675 -> 2.68, 647568.815 -> 647568.82 HALF_UP ties. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
