Weixin-Xu commented on code in PR #13492: URL: https://github.com/apache/gluten/pull/13492#discussion_r4421642592
########## cpp/bolt/jni/BoltJniWrapper.cc: ########## @@ -1006,8 +1005,10 @@ JNIEXPORT void JNICALL Java_org_apache_gluten_shuffle_BoltShuffleWriterJniWrappe // The column batch maybe BoltColumnBatch or ArrowCStructColumnarBatch(FallbackRangeShuffleWriter) auto batch = ObjectStore::retrieve<ColumnarBatch>(batchHandle); + const auto inputBytes = batch->numBytes(); Review Comment: Removed the unused numBytes() calculation and changed the Bolt shuffle JNI write() contract to return void. This avoids flattening batches solely for discarded accounting. Uniffle’s dataSize continues to use the final raw partition lengths after stop(), including the final flush. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
