Copilot commented on code in PR #13520:
URL: https://github.com/apache/gluten/pull/13520#discussion_r4439382243
##########
.github/workflows/util/install-spark-resources.sh:
##########
@@ -131,6 +131,13 @@ if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
mv "${INSTALL_DIR}/shims/spark42/spark_home/assembly/target/scala-2.12" \
"${INSTALL_DIR}/shims/spark42/spark_home/assembly/target/scala-2.13"
;;
+ 4.3)
+ # Spark-4.x, scala 2.12 // using 2.12 as a hack as 4.3 does not have a
2.13 suffix
+ cd ${INSTALL_DIR} && \
+ install_spark "4.3.0" "3" "2.12"
+ mv "${INSTALL_DIR}/shims/spark43/spark_home/assembly/target/scala-2.12" \
+ "${INSTALL_DIR}/shims/spark43/spark_home/assembly/target/scala-2.13"
Review Comment:
The Spark 4.3 jobs run this installer unconditionally, but the updated CI
Dockerfile also installs these resources. Once the image is rebuilt, a second
install fails when `mv python` encounters the existing nonempty
`spark_home/python` directory, so every Spark 4.3 test job stops before running
tests. Please skip installation when the complete Spark 4.3 resources are
already present, or make the installation safely replace them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
