ggjh-159 commented on code in PR #13409:
URL: https://github.com/apache/gluten/pull/13409#discussion_r4466225316
##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/NexmarkTest.java:
##########
@@ -419,15 +454,30 @@ private boolean checkJobRunningStatus(TableResult result,
long timeoutMs)
if (jobClient.getJobStatus().complete(JobStatus.RUNNING)) {
jobClient.cancel();
return true;
- } else {
- Thread.sleep(1000);
}
+ if (jobClient.getJobStatus().complete(JobStatus.FAILED)) {
+ LOG.warn("Job failed before reaching RUNNING state.");
+ return jobFailedOnUnsupportedFeature(jobClient);
+ }
+ Thread.sleep(1000);
}
LOG.warn("Job not running in " + timeoutMs + " millseconds.");
jobClient.cancel();
return false;
}
+ private boolean jobFailedOnUnsupportedFeature(JobClient jobClient) throws
InterruptedException {
+ try {
+ jobClient.getJobExecutionResult().get();
+ } catch (ExecutionException e) {
+ if (isCausedByUnsupportedFeature(e)) {
+ LOG.warn("Job failed on an unsupported stream feature; tolerating the
failure.", e);
+ return true;
Review Comment:
An unsupported-feature failure now skips the test via Assumptions.abort, so
true is reserved for a job that actually reached RUNNING.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
