AnissaLiu commented on PR #13491: URL: https://github.com/apache/gluten/pull/13491#issuecomment-6678170969
Good point on the baseline. Two distinct issues were behind the red CI: 1. This PR (fixed in d71383ffe): the velox4j pin sat at 1cf413f6, which predates velox4j#65 (adapt keyed state framework) — that is where io.github.zhztheplayer.velox4j.plan.KeyGroupPartitionFunctionSpec comes from, and the keyed exchange routing already on main (#13409) imports it, so gluten-flink failed to compile with "cannot find symbol". The pin now moves to cfe63ea5, which merges #65 on top of 1cf413f6 (the temporal work stays included), and the fix-velox4j.patch still applies cleanly on it. 2. The pre-existing baseline failures: GlutenStreamTwoInputWatermarkStatusTest has 4 errors reproducible on main itself (StreamJoin is not yet migrated to operator-owned keyed state — the stateful framework fail-fast gate). Note the flink workflow skips the unit-test step on schedule runs (if: github.event_name != 'schedule'), so main's dailies stay green and these only surface on PR runs — which is exactly why they force per-PR human judgment. Agreed they belong in a separate baseline PR; the StreamJoin migration is with the stateful framework owners. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
