rdtr commented on PR #13263: URL: https://github.com/apache/gluten/pull/13263#issuecomment-6680186938
@philo-he @LuciferYang Sounds good, I'll pick up the tag. I also rebased this PR onto main, so the Spark 3.5 jobs get the fix from #13371. Today the ANSI workflow runs all of backends-velox and every spark-ut suite (`-DwildcardSuites='org.apache.spark.'`) with ANSI on. That is mostly the same set as the regular CI. I'll add a tag, `org.apache.gluten.tags.AnsiTest`, put it on the suites whose results depend on ANSI mode (cast, arithmetic, date/time, collection and aggregate functions, error conditions), and run the ANSI jobs with `-DtagsToInclude` instead of the full set. The PR will list the tagged suites so it's easy to review which ones are in. Should this PR wait for the tag PR, or go in first and switch to the tag afterwards? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
