philo-he commented on PR #13400: URL: https://github.com/apache/gluten/pull/13400#issuecomment-6718385758
@rdtr, thanks for the PR! I feel it seems not quite necessary to enable this test. Could you check whether the following comment makes sense? Is this Gluten version needed? The write here is `USING json`, which the Velox backend doesn't write natively (only Parquet/Hive), so the permission failure is raised and propagated entirely by Spark's own writer, and Gluten adds no coverage. Also, `setWritable(false)` has no effect for root, so in CI the `assume(!childPath.mkdir(), ...)` check cancels the test on every run. I'd keep only the exclude with the corrected comment. If we want to check that a native write failure surfaces as `Job aborted` on the driver, a Parquet-based test would be the one that exercises Gluten's path. One thing we can keep in mind is, not every Spark original test is really necessary to be enabled in Gluten. For instance, some of those are not related to Gluten, and some others require some modifications to really exercise Gluten code path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
