anshulbaliga7 commented on issue #13253: URL: https://github.com/apache/gluten/issues/13253#issuecomment-6771188759
Thanks @zhouyuan. The removal turned out to be straightforward, so I’ve opened #13610 and we can judge from the diff. Two places used the “off” mode: `VeloxBroadcastBuildOnceBenchmark`, which only existed to compare the two modes, and `DynamicOffHeapSizingSuite` which disabled it with a note that the native build needs off-heap memory. The PR removes the benchmark and lets that suite build once per executor like everything else. The per-task build stays only for whole-stage dumping which the micro benchmark relies on. CI is green too. @JkSelf since you added the option, is there a debugging scenario where you still want to force a per-task build? If so, keeping and documenting the option is the easy fallback. Please let know, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
