malinjawi commented on code in PR #12647:
URL: https://github.com/apache/gluten/pull/12647#discussion_r4527573974
##########
backends-velox/src-delta4/main/scala/org/apache/spark/sql/delta/GlutenOptimisticTransaction.scala:
##########
@@ -175,7 +181,8 @@ class GlutenOptimisticTransaction(delegate:
OptimisticTransaction)
if (nativeUnsupportedReason.isEmpty) {
GlutenDeltaFileFormatWriter.write(
sparkSession = spark,
- plan = glutenPhysicalPlan(spark, empty2NullPlan, constraints,
isOptimize, writeOptions),
+ plan = glutenPhysicalPlan(
+ spark, empty2NullPlan, constraints, nativeInvariantChecker,
isOptimize, writeOptions),
Review Comment:
Good idea added this in 13b7af96ce so`glutenPhysicalPlan` now creates the
checker itself and its arguments are back to what they are on main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]