marin-ma commented on code in PR #13530:
URL: https://github.com/apache/gluten/pull/13530#discussion_r4530664670


##########
backends-velox/src/test/scala/org/apache/gluten/expression/VeloxUdfSuite.scala:
##########
@@ -369,35 +369,22 @@ class VeloxUdfSuiteLocal extends VeloxUdfSuite {
 //
 // VM options:
 // -Dspark.test.home=${SPARK_HOME}
-// -Dgluten.package.jar=\
-// /path/to/gluten/package/target/gluten-package-${project.version}.jar
 // -Dvelox.udf.lib.path=\
 // /path/to/gluten/cpp/build/velox/udf/examples/libmyudf.so
-@SkipTest
+@UDFTest
 class VeloxUdfSuiteCluster extends VeloxUdfSuite {
 
   override val master: String = "local-cluster[2,2,1024]"
 
-  val GLUTEN_JAR: String = "gluten.package.jar"
-
-  private lazy val glutenJar = sys.props.get(GLUTEN_JAR) match {
-    case Some(jar) => jar
-    case None =>
-      throw new IllegalArgumentException(
-        GLUTEN_JAR + s" cannot be null. You may set it by adding " +
-          s"-D$GLUTEN_JAR=" +
-          
"/path/to/gluten/package/target/gluten-package-${project.version}.jar")
-  }
-
   private lazy val driverUdfLibPath =
-    udfLibPath.split(",").map("file://" + _).mkString(",")
+    udfLibPath.split(",").map(p => 
Paths.get(p).toAbsolutePath.toUri.toString).mkString(",")
 
   override protected def sparkConf: SparkConf = {
     super.sparkConf
       .set("spark.files", udfLibPath)
       .set(VeloxBackendSettings.GLUTEN_VELOX_DRIVER_UDF_LIB_PATHS, 
driverUdfLibPath)
       .set(VeloxBackendSettings.GLUTEN_VELOX_UDF_LIB_PATHS, udfLibRelativePath)
-      .set("spark.driver.extraClassPath", glutenJar)
-      .set("spark.executor.extraClassPath", glutenJar)
+      .set("spark.executor.extraClassPath", sys.props("java.class.path"))
+      .set(VeloxConfig.NATIVE_UDF_BYPASS_REGISTRATION.key, "true")

Review Comment:
   @kevinwilfong Sorry for the delayed review. Is it possible to test the 
non-bypass configuration as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to