rdtr commented on PR #13351:
URL: https://github.com/apache/gluten/pull/13351#issuecomment-6809708718

   @ReemaAlzaid Following up on my comment in 
https://github.com/facebookincubator/velox/pull/19522#issuecomment-6808781493: 
if decimal `pmod` reads `spark.ansi_enabled` like primitive `pmod` 
(https://github.com/facebookincubator/velox/pull/19231), this PR gets simpler. 
Gluten maps `Pmod` to `pmod` / `pmod_deny_precision_loss` in both modes, and 
the `checked_` name, the `try` wrapper for LEGACY and the 
`enableNativeValidation` check can go. A session mode that differs from the 
captured one is handled by https://github.com/apache/gluten/pull/13529, which 
falls back for `Pmod` when its `evalMode` differs from the session. The test 
`decimal pmod preserves captured ANSI mode after physical planning` would then 
expect a fallback, and the docs paragraph can drop the captured-mode sentence.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to